kubeadm/cilium: bump tested versions #291
Conversation
Signed-off-by: Mathieu Tortuyaux <[email protected]>
in previous cilium-cli version, it was not possible to set the Cilium version from the CLI, we were relying on the compiled default version. it's now easier to update cilium itself and to know which version is actually being tested. Signed-off-by: Mathieu Tortuyaux <[email protected]>
we assert that the cilium install script is correctly loaded with the cilium version. Signed-off-by: Mathieu Tortuyaux <[email protected]>
CHANGELOG.md
Outdated
| @@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| - removed `packet` occurrences in favor of `equinixmetal` ([#277](https://github.com/flatcar-linux/mantle/pull/277)) | |||
| - kola: fixed cl.filesystem test for systemd 250 and newer ([#280](https://github.com/flatcar-linux/mantle/pull/280)) | |||
| - PXE boots now over HTTPS on Equinix Metal ([#288](https://github.com/flatcar-linux/mantle/pull/288)) | |||
| - cilium tested version to 1.11.1 ([291](https://github.com/flatcar-linux/mantle/pull/291)) | |||
There was a problem hiding this comment.
yeah that's a good point actually.
I personally have the habit to read section from title to the bullet point. So
## Changed
- cilium tested version to 1.11.1
can be read as "changed cilium tested version to 1.11.1". It avoids redundancy like:
## Changed
- Changed cilium tested version to 1.11.1
There was a problem hiding this comment.
yeah that's a good point actually.
I personally have the habit to read section from title to the bullet point. So
## Changed - cilium tested version to 1.11.1can be read as "changed cilium tested version to 1.11.1".
Clearly the other entries are not following your habit. :) Not saying that your habit is bad or wrong, but the entry looks odd without a verb.
It avoids redundancy like:
## Changed - Changed cilium tested version to 1.11.1
Yeah, I'd use some more specific verb than "changed", like "bumped" or "updated".
There was a problem hiding this comment.
Ok, let's do that then !
That's not an issue, it's a We only check that uploaded templates on worker/controller are correctly rendered. |
Ok, thanks for checking! |
tormath1
force-pushed
the
tormath1/cilium
branch
from
2f39bbd to
4e3bb8f
Compare
Signed-off-by: Mathieu Tortuyaux <[email protected]>
tormath1
force-pushed
the
tormath1/cilium
branch
from
4e3bb8f to
d1744d9
Compare
In this PR, we bump the cilium version to latest v1.11.0 and we give the ability to set the version from the
cilium-clidirectly, since it has been introduced in the CLI.This PR aims to have a more recent version of the tested cilium in order to prepare the introduction of a new test to validate the behavior of IPSec + cilium.
Testing done
kubeadm.v1.23.0.cilium.basechangelog/directory (user-facing change, bug fix, security fix, update)